From 1eded07f001b73d6ebf1b24a25f6b803e6288bd5 Mon Sep 17 00:00:00 2001 From: Remington Brasga Date: Wed, 23 Jan 2019 10:19:27 -0800 Subject: [PATCH] Bug in Regular Expression in Makefile (#4682) Summary: False-negative about path not existing. The regex is ignoring the "." in front of a path. Example: "./path/to/file" Pull Request resolved: https://github.com/facebook/rocksdb/pull/4682 Differential Revision: D13777110 Pulled By: sagar0 fbshipit-source-id: 9f8173b7581407555fdc055580732aeab37d4ade --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b4a84db2d..07e8d0fa6 100644 --- a/Makefile +++ b/Makefile @@ -198,7 +198,7 @@ include make_config.mk CLEAN_FILES += make_config.mk missing_make_config_paths := $(shell \ - grep "\/\S*" -o $(CURDIR)/make_config.mk | \ + grep "./\S*\|/\S*" -o $(CURDIR)/make_config.mk | \ while read path; \ do [ -e $$path ] || echo $$path; \ done | sort | uniq)