andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix compilation error when building static_lib (#9377)

Browse Source 
Summary:
With memkind installed, either on a non-fb machine or using `ROCKSDB_NO_FBCODE=1`.

```
ROCKSDB_NO_FBCODE=1 make static_lib
```

Compilation failed due to unused variable warning treated as error. To bypass this, we need to
disable warning-as-error, which is not ideal.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9377

Test Plan: Repeat the above command, and rely on CI.

Reviewed By: ajkr

Differential Revision: D33543343

Pulled By: riversand963

fbshipit-source-id: 9a2790b38c00b8696c7910287f4ae5a9b394341d
This commit is contained in:
Yanqin Jin 2022-01-12 09:02:43 -08:00 committed by Facebook GitHub Bot
parent f8bdd5797f
commit 21e71d1c73
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
memory/memkind_kmem_allocator.h
View File

@ -22,6 +22,7 @@ class MemkindKmemAllocator : public BaseMemoryAllocator {
static bool IsSupported(std::string* msg) { static bool IsSupported(std::string* msg) {
#ifdef MEMKIND #ifdef MEMKIND
(void)msg;
return true; return true;
#else #else
*msg = "Not compiled with MemKind"; *msg = "Not compiled with MemKind";