andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add valgrind to pre-commit sandcastle testing

Browse Source 
Summary:
Initially I removed "valgrind" from the list since it take too much
time (3+hr) compared to tsan (40 min) when the tests are run in parallel. It is
not effective to run the tests in parallel in sandcastle and tsan takes about
3hrs as well.

Adding valgrind to the list.

Test Plan: Submit this diff and watch the run

Reviewers: sdong, rven

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D53337
This commit is contained in:
krad 2016-01-25 13:06:11 -08:00
parent b7ecf3d214
commit 22ecb752db
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arcanist_util/config/FacebookArcanistConfiguration.php
View File

@ -123,7 +123,7 @@ class FacebookArcanistConfiguration extends ArcanistConfiguration {
// list of tests we want to run in sandcastle
$tests = array(
"unit", "unit_481", "clang_unit", "tsan", "asan", "lite"
"unit", "unit_481", "clang_unit", "tsan", "asan", "lite", "valgrind"
);
// construct a job definition for each test and add it to the master plan