From 2367656b6c19048d76037d24025ef0caab136866 Mon Sep 17 00:00:00 2001 From: Yikun Jiang Date: Mon, 23 Sep 2019 12:13:24 -0700 Subject: [PATCH] Remove invalid comparison of va_list and nullptr (#5836) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: The comparison of va_list and nullptr is always False under any arch, and will raise invalid operands of types error in aarch64 env (`error: invalid operands of types ‘va_list {aka __va_list}’ and ‘std::nullptr_t’ to binary ‘operator!=’`). This patch removes this invalid assert. Closes: https://github.com/facebook/rocksdb/issues/4277 Pull Request resolved: https://github.com/facebook/rocksdb/pull/5836 Differential Revision: D17532470 fbshipit-source-id: ca98078ecbc6a9416c69de3bd6ffcfa33a0f0185 --- java/rocksjni/loggerjnicallback.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/java/rocksjni/loggerjnicallback.cc b/java/rocksjni/loggerjnicallback.cc index 61571e987..a731fdac9 100644 --- a/java/rocksjni/loggerjnicallback.cc +++ b/java/rocksjni/loggerjnicallback.cc @@ -131,7 +131,6 @@ void LoggerJniCallback::Logv(const InfoLogLevel log_level, const char* format, } assert(format != nullptr); - assert(ap != nullptr); const std::unique_ptr msg = format_str(format, ap); // pass msg to java callback handler