andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove the experimental notes about partitioning

Browse Source 
Summary:
This patch will remove the existing comments that declare partitioning indexes and filters as experimental.
Closes https://github.com/facebook/rocksdb/pull/3115

Differential Revision: D6222227

Pulled By: maysamyabandeh

fbshipit-source-id: 6179ec43b22c518494051b674d91c9e1b54d4ac0
This commit is contained in:
Maysam Yabandeh 2017-11-02 11:06:10 -07:00 committed by Facebook Github Bot
parent 60d83df23d
commit 25fbd9a996
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/rocksdb/table.h
View File

@ -87,9 +87,6 @@ struct BlockBasedTableOptions {
// `Options.prefix_extractor` is provided. // `Options.prefix_extractor` is provided.
kHashSearch, kHashSearch,
// TODO(myabandeh): this feature is in experimental phase and shall not be
// used in production; either remove the feature or remove this comment if
// it is ready to be used in production.
// A two-level index implementation. Both levels are binary search indexes. // A two-level index implementation. Both levels are binary search indexes.
kTwoLevelIndexSearch, kTwoLevelIndexSearch,
}; };
@ -158,10 +155,8 @@ struct BlockBasedTableOptions {
// Note: currently this option requires kTwoLevelIndexSearch to be set as // Note: currently this option requires kTwoLevelIndexSearch to be set as
// well. // well.
// TODO(myabandeh): remove the note above once the limitation is lifted // TODO(myabandeh): remove the note above once the limitation is lifted
// TODO(myabandeh): this feature is in experimental phase and shall not be // Use partitioned full filters for each SST file. This option is
// used in production; either remove the feature or remove this comment if // incompatibile with block-based filters.
// it is ready to be used in production.
// Use partitioned full filters for each SST file
bool partition_filters = false; bool partition_filters = false;
// Use delta encoding to compress keys in blocks. // Use delta encoding to compress keys in blocks.