andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Rename mutable_cf_options to signify explicity copy (#9666)

Browse Source 
Summary:
Signify explicit copy with comment and better name for variable `mutable_cf_options`

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9666

Reviewed By: riversand963

Differential Revision: D34680934

Pulled By: ezgicicek

fbshipit-source-id: b64ef18725fe523835d14ceb4b29bcdfe493f8ed
This commit is contained in:
Ezgi Çiçek 2022-03-08 11:26:40 -08:00 committed by Facebook GitHub Bot
parent c967436453
commit 27d6ef8e60
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
db/db_impl/db_impl_compaction_flush.cc
View File

@ -382,13 +382,14 @@ Status DBImpl::FlushMemTablesToOutputFiles(
&earliest_write_conflict_snapshot, &snapshot_checker); &earliest_write_conflict_snapshot, &snapshot_checker);
const auto& bg_flush_arg = bg_flush_args[0]; const auto& bg_flush_arg = bg_flush_args[0];
ColumnFamilyData* cfd = bg_flush_arg.cfd_; ColumnFamilyData* cfd = bg_flush_arg.cfd_;
MutableCFOptions mutable_cf_options = *cfd->GetLatestMutableCFOptions(); // intentional infrequent copy for each flush
MutableCFOptions mutable_cf_options_copy = *cfd->GetLatestMutableCFOptions();
SuperVersionContext* superversion_context = SuperVersionContext* superversion_context =
bg_flush_arg.superversion_context_; bg_flush_arg.superversion_context_;
Status s = FlushMemTableToOutputFile( Status s = FlushMemTableToOutputFile(
cfd, mutable_cf_options, made_progress, job_context, superversion_context, cfd, mutable_cf_options_copy, made_progress, job_context,
snapshot_seqs, earliest_write_conflict_snapshot, snapshot_checker, superversion_context, snapshot_seqs, earliest_write_conflict_snapshot,
log_buffer, thread_pri); snapshot_checker, log_buffer, thread_pri);
return s; return s;
} }