From 28bab0ef7ebe4e915cff9adc93df98e15ccf4a74 Mon Sep 17 00:00:00 2001 From: Siying Dong Date: Thu, 4 Nov 2021 16:36:48 -0700 Subject: [PATCH] Improve comments on options.writable_file_max_buffer_size (#9131) Summary: Comments of options.writable_file_max_buffer_size mentioned Windows, which is confusing. Remove it. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9131 Reviewed By: anand1976 Differential Revision: D32187003 fbshipit-source-id: 1f134d7ecdc4a9d13825d461ab1da56769b9455f --- include/rocksdb/options.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rocksdb/options.h b/include/rocksdb/options.h index 7a1de8266..00b070c0e 100644 --- a/include/rocksdb/options.h +++ b/include/rocksdb/options.h @@ -934,7 +934,7 @@ struct DBOptions { size_t random_access_max_buffer_size = 1024 * 1024; // This is the maximum buffer size that is used by WritableFileWriter. - // On Windows, we need to maintain an aligned buffer for writes. + // With direct IO, we need to maintain an aligned buffer for writes. // We allow the buffer to grow until it's size hits the limit in buffered // IO and fix the buffer size when using direct IO to ensure alignment of // write requests if the logical sector size is unusual