andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Deflake BlobDBTest.SnapshotAndGarbageCollection (#8444)

Browse Source 
Summary:
This test case has been failing occasionally due to automatic
compactions kicking in, resulting in GC generating additional
blob files that the test did not expect. Disabling automatic
compactions to get rid of this flakiness.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8444

Test Plan: `gtest-parallel --repeat=1000 ./blob_db_test --gtest_filter="BlobDBTest.SnapshotAndGarbageCollection"`

Reviewed By: jay-zhuang

Differential Revision: D29316987

Pulled By: ltamasi

fbshipit-source-id: 9815d189ed7d63890622768675a01990e3680221
This commit is contained in:
Levi Tamasi 2021-06-22 17:33:15 -07:00 committed by Facebook GitHub Bot
parent 005c046734
commit 3ab0eae860
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
utilities/blob_db/blob_db_test.cc
View File

@ -871,10 +871,13 @@ TEST_F(BlobDBTest, SnapshotAndGarbageCollection) {
bdb_options.garbage_collection_cutoff = 1.0;
bdb_options.disable_background_tasks = true;
Options options;
options.disable_auto_compactions = true;
// i = when to take snapshot
for (int i = 0; i < 4; i++) {
Destroy();
Open(bdb_options);
Open(bdb_options, options);
const Snapshot *snapshot = nullptr;