andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove incorrect assert in GetUniqueIdFromFile (#5102)

Browse Source 
Summary:
User report has shown that sometimes `BlockBasedTable::SetupCacheKeyPrefix` would assert when trying to generate an id from the file. The actual cause seems to be hardware related but we might be better off without the incorrect assertion
See T42178927 for more information
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5102

Differential Revision: D14604677

Pulled By: miasantreble

fbshipit-source-id: fcb09207ebdc4fa66e941afbc0523d84797e7ad7
This commit is contained in:
Zhongyi Xie 2019-03-25 23:22:14 -07:00 committed by Facebook Github Bot
parent 48e7effa79
commit 3c5eed5ebe
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
env/io_posix.cc vendored
View File

@ -265,7 +265,6 @@ size_t PosixHelper::GetUniqueIdFromFile(int fd, char* id, size_t max_size) {
struct stat buf; struct stat buf;
int result = fstat(fd, &buf); int result = fstat(fd, &buf);
assert(result != -1);
if (result == -1) { if (result == -1) {
return 0; return 0;
} }