From 3cfc7515fcce7b41f24951f36d89405ae764f0e7 Mon Sep 17 00:00:00 2001 From: Sagar Vemuri Date: Wed, 16 Jan 2019 11:23:42 -0800 Subject: [PATCH] Remove an unused option (#4888) Summary: Remove `garbage_collection_deletion_size_threshold` as it is not used anywhere. Pull Request resolved: https://github.com/facebook/rocksdb/pull/4888 Differential Revision: D13685982 Pulled By: sagar0 fbshipit-source-id: e08d3017b9a0c8fa99bc332b595ee4ed9db70c87 --- utilities/blob_db/blob_db.cc | 3 --- utilities/blob_db/blob_db.h | 4 ---- 2 files changed, 7 deletions(-) diff --git a/utilities/blob_db/blob_db.cc b/utilities/blob_db/blob_db.cc index 9e4e61741..11c59a6b1 100644 --- a/utilities/blob_db/blob_db.cc +++ b/utilities/blob_db/blob_db.cc @@ -96,9 +96,6 @@ void BlobDBOptions::Dump(Logger* log) const { ROCKS_LOG_HEADER( log, " BlobDBOptions.garbage_collection_interval_secs: %" PRIu64, garbage_collection_interval_secs); - ROCKS_LOG_HEADER( - log, "BlobDBOptions.garbage_collection_deletion_size_threshold: %lf", - garbage_collection_deletion_size_threshold); ROCKS_LOG_HEADER( log, " BlobDBOptions.disable_background_tasks: %d", disable_background_tasks); diff --git a/utilities/blob_db/blob_db.h b/utilities/blob_db/blob_db.h index 1eee9fcc3..d07703185 100644 --- a/utilities/blob_db/blob_db.h +++ b/utilities/blob_db/blob_db.h @@ -76,10 +76,6 @@ struct BlobDBOptions { // Time interval to trigger garbage collection, in seconds. uint64_t garbage_collection_interval_secs = 60; - // If garbage collection is enabled, blob files with deleted size no less - // than this ratio will become candidates to be cleanup. - double garbage_collection_deletion_size_threshold = 0.75; - // Disable all background job. Used for test only. bool disable_background_tasks = false;