andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not cache readahead-pages in the OS cache.

Browse Source 
Summary:
When posix_fadvise(offset, offset) is usedm it frees up only those
pages in that specified range. But the filesystem could have done some
read-aheads and those get cached in the OS cache.

Do not cache readahead-pages in the OS cache.

Test Plan: run db_bench benchmark.

Reviewers: vamsi, heyongqiang

Reviewed By: heyongqiang

Differential Revision: https://reviews.facebook.net/D5379
This commit is contained in:
Dhruba Borthakur 2012-09-13 10:10:51 -07:00
parent 7ecc5d4ad5
commit 4028ae7d31
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/env_posix.cc
View File

@ -94,7 +94,9 @@ class PosixRandomAccessFile: public RandomAccessFile {
s = IOError(filename_, errno); s = IOError(filename_, errno);
} }
if (!useOsBuffer) { if (!useOsBuffer) {
posix_fadvise(fd_, offset, n, POSIX_FADV_DONTNEED); // free OS pages // we need to fadvise away the entire range of pages because
// we do not want readahead pages to be cached.
posix_fadvise(fd_, 0, 0, POSIX_FADV_DONTNEED); // free OS pages
} }
return s; return s;
} }