andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove Ticker::SEQUENCE_NUMBER

Browse Source 
Summary:
Remove the ticker count because:
* Having to reset the ticker count in WriteImpl is ineffiecent;
* It doesn't make sense to have it as a ticker count if multiple db
  instance share a statistics object.
Closes https://github.com/facebook/rocksdb/pull/1531

Differential Revision: D4194442

Pulled By: yiwu-arbug

fbshipit-source-id: e2110a9
This commit is contained in:
Yi Wu 2016-11-16 22:34:18 -08:00 committed by Islam AbdelRahman
parent 1412fd9a35
commit 41526f44f6
3 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
db/db_impl.cc
View File

@ -1348,7 +1348,6 @@ Status DBImpl::Recover(
} }
} }
} }
SetTickerCount(stats_, SEQUENCE_NUMBER, versions_->LastSequence());
} }
// Initial value // Initial value
@ -4630,7 +4629,6 @@ Status DBImpl::WriteImpl(const WriteOptions& write_options,
if (write_thread_.CompleteParallelWorker(&w)) { if (write_thread_.CompleteParallelWorker(&w)) {
// we're responsible for early exit // we're responsible for early exit
auto last_sequence = w.parallel_group->last_sequence; auto last_sequence = w.parallel_group->last_sequence;
SetTickerCount(stats_, SEQUENCE_NUMBER, last_sequence);
versions_->SetLastSequence(last_sequence); versions_->SetLastSequence(last_sequence);
write_thread_.EarlyExitParallelGroup(&w); write_thread_.EarlyExitParallelGroup(&w);
} }
@ -4966,7 +4964,6 @@ Status DBImpl::WriteImpl(const WriteOptions& write_options,
} }
if (!exit_completed_early && w.status.ok()) { if (!exit_completed_early && w.status.ok()) {
SetTickerCount(stats_, SEQUENCE_NUMBER, last_sequence);
versions_->SetLastSequence(last_sequence); versions_->SetLastSequence(last_sequence);
if (!need_log_sync) { if (!need_log_sync) {
write_thread_.ExitAsBatchGroupLeader(&w, last_writer, w.status); write_thread_.ExitAsBatchGroupLeader(&w, last_writer, w.status);

2
include/rocksdb/statistics.h
View File

@ -152,7 +152,6 @@ enum Tickers : uint32_t {
// written to storage because key does not exist // written to storage because key does not exist
NUMBER_FILTERED_DELETES, NUMBER_FILTERED_DELETES,
NUMBER_MERGE_FAILURES, NUMBER_MERGE_FAILURES,
SEQUENCE_NUMBER,
// number of times bloom was checked before creating iterator on a // number of times bloom was checked before creating iterator on a
// file, and the number of times the check was useful in avoiding // file, and the number of times the check was useful in avoiding
@ -280,7 +279,6 @@ const std::vector<std::pair<Tickers, std::string>> TickersNameMap = {
{NUMBER_MULTIGET_BYTES_READ, "rocksdb.number.multiget.bytes.read"}, {NUMBER_MULTIGET_BYTES_READ, "rocksdb.number.multiget.bytes.read"},
{NUMBER_FILTERED_DELETES, "rocksdb.number.deletes.filtered"}, {NUMBER_FILTERED_DELETES, "rocksdb.number.deletes.filtered"},
{NUMBER_MERGE_FAILURES, "rocksdb.number.merge.failures"}, {NUMBER_MERGE_FAILURES, "rocksdb.number.merge.failures"},
{SEQUENCE_NUMBER, "rocksdb.sequence.number"},
{BLOOM_FILTER_PREFIX_CHECKED, "rocksdb.bloom.filter.prefix.checked"}, {BLOOM_FILTER_PREFIX_CHECKED, "rocksdb.bloom.filter.prefix.checked"},
{BLOOM_FILTER_PREFIX_USEFUL, "rocksdb.bloom.filter.prefix.useful"}, {BLOOM_FILTER_PREFIX_USEFUL, "rocksdb.bloom.filter.prefix.useful"},
{NUMBER_OF_RESEEKS_IN_ITERATION, "rocksdb.number.reseeks.iteration"}, {NUMBER_OF_RESEEKS_IN_ITERATION, "rocksdb.number.reseeks.iteration"},

1
java/src/main/java/org/rocksdb/TickerType.java
View File

@ -87,7 +87,6 @@ public enum TickerType {
// written to storage because key does not exist // written to storage because key does not exist
NUMBER_FILTERED_DELETES(36), NUMBER_FILTERED_DELETES(36),
NUMBER_MERGE_FAILURES(37), NUMBER_MERGE_FAILURES(37),
SEQUENCE_NUMBER(38),
// number of times bloom was checked before creating iterator on a // number of times bloom was checked before creating iterator on a
// file, and the number of times the check was useful in avoiding // file, and the number of times the check was useful in avoiding