andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove unnecessary fadvise

Browse Source 
Summary:
We has to remove this line because previously it is only called when use_os_buffer = false. But now we have direct io to replace it.
Closes https://github.com/facebook/rocksdb/pull/2573

Differential Revision: D5412824

Pulled By: yiwu-arbug

fbshipit-source-id: 81f3f0cdf94566bfc09ef2ff123e40cddbe36b36
This commit is contained in:
Aaron Gao 2017-07-12 18:00:45 -07:00 committed by Facebook Github Bot
parent 21b17d7686
commit 43e4eef77f
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
env/io_posix.cc vendored
View File

@ -172,9 +172,6 @@ Status PosixSequentialFile::Read(size_t n, Slice* result, char* scratch) {
s = IOError("While reading file sequentially", filename_, errno);
}
}
// we need to fadvise away the entire range of pages because
// we do not want readahead pages to be cached under buffered io
Fadvise(fd_, 0, 0, POSIX_FADV_DONTNEED); // free OS pages
return s;
}