andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

"make commit-prereq" doesn't really build ROCKSDB_LITE

Browse Source 
Summary: "make commit-prereq" uses "make release" which overrides OPT, so ROCKSDB_LITE is not covered. Fix it by using "make static_lib"

Test Plan: Run it and see it fail (which is expected)

Reviewers: yhchiang, meyering, rven, anthony, kradhakrishnan, igor

Reviewed By: igor

Subscribers: leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D36813
This commit is contained in:
sdong 2015-04-09 16:55:25 -07:00
parent d2a056241a
commit 465b25ca93
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -921,7 +921,7 @@ commit-prereq:
$(MAKE) clean && $(MAKE) all check; $(MAKE) clean && $(MAKE) all check;
$(MAKE) clean && $(MAKE) rocksdbjava; $(MAKE) clean && $(MAKE) rocksdbjava;
$(MAKE) clean && USE_CLANG=1 $(MAKE) all; $(MAKE) clean && USE_CLANG=1 $(MAKE) all;
$(MAKE) clean && OPT=-DROCKSDB_LITE $(MAKE) release; $(MAKE) clean && OPT=-DROCKSDB_LITE $(MAKE) static_lib;
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# Platform-specific compilation # Platform-specific compilation