From 48da7a9cad76f1a736e54a495525c7721f4a9967 Mon Sep 17 00:00:00 2001 From: Yueh-Hsuan Chiang Date: Wed, 24 Jun 2015 15:00:51 -0700 Subject: [PATCH] Improve the comment for BYTES_READ in statistics. Summary: BYTES_READ only count the number of logical bytes read from the DB::Get() function. It neither includes all logical bytes read nor indicates IO read bytes. This patch improves the comment for BYTES_READ. Test Plan: Only change comment. Reviewers: sdong, rven, anthony, kradhakrishnan, IslamAbdelRahman, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D40599 --- include/rocksdb/statistics.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/rocksdb/statistics.h b/include/rocksdb/statistics.h index 56d01aaf3..82405276d 100644 --- a/include/rocksdb/statistics.h +++ b/include/rocksdb/statistics.h @@ -74,8 +74,13 @@ enum Tickers : uint32_t { NUMBER_KEYS_READ, // Number keys updated, if inplace update is enabled NUMBER_KEYS_UPDATED, - // Bytes written / read + // The number of uncompressed bytes issued by DB::Put(), DB::Delete(), + // DB::Merge(), and DB::Write(). BYTES_WRITTEN, + // The number of uncompressed bytes read from DB::Get(). It could be + // either from memtables, cache, or table files. + // For the number of logical bytes read from DB::MultiGet(), + // please use NUMBER_MULTIGET_BYTES_READ. BYTES_READ, NO_FILE_CLOSES, NO_FILE_OPENS,