From 4c2aef04bdd8538a9c2d6199f71d50fa9ab83a7e Mon Sep 17 00:00:00 2001 From: Cheng Chang Date: Fri, 6 Nov 2020 09:57:09 -0800 Subject: [PATCH] ColumnFamilyTest often times out in internal test infra (#7638) Summary: Tries to fix by skipping fsync. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7638 Test Plan: watch the tests to pass Reviewed By: jay-zhuang Differential Revision: D24764355 Pulled By: cheng-chang fbshipit-source-id: 9c21b177709025ca1943066d94da89324ed47655 --- db/column_family_test.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/db/column_family_test.cc b/db/column_family_test.cc index 48aa4b12a..ea55dbedd 100644 --- a/db/column_family_test.cc +++ b/db/column_family_test.cc @@ -35,10 +35,10 @@ namespace ROCKSDB_NAMESPACE { static const int kValueSize = 1000; // counts how many operations were performed -class EnvCounter : public EnvWrapper { +class EnvCounter : public SpecialEnv { public: explicit EnvCounter(Env* base) - : EnvWrapper(base), num_new_writable_file_(0) {} + : SpecialEnv(base), num_new_writable_file_(0) {} int GetNumberOfNewWritableFileCalls() { return num_new_writable_file_; } @@ -68,6 +68,7 @@ class ColumnFamilyTestBase : public testing::Test { #endif // !ROCKSDB_LITE EXPECT_NE(nullptr, base_env); env_ = new EnvCounter(base_env); + env_->skip_fsync_ = true; dbname_ = test::PerThreadDBPath("column_family_test"); db_options_.create_if_missing = true; db_options_.fail_if_options_file_error = true;