andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert changes in PR #4003 (#4263)

Browse Source 
Summary:
Revert this change. Not generating the OnTableFileCreated() notification for a 0 byte SST on flush breaks the assumption that every OnTableFileCreationStarted() notification is followed by a corresponding OnTableFileCreated().
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4263

Differential Revision: D9285623

Pulled By: anand1976

fbshipit-source-id: 808c3dcd498b4b4f4ed4be947a29a24b2296aa8d
This commit is contained in:
Anand Ananthabhotla 2018-08-11 16:44:11 -07:00 committed by Facebook Github Bot
parent 6d75319d95
commit 4ea56b1bd0
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
db/builder.cc
View File

@ -230,11 +230,9 @@ Status BuildTable(
} }
// Output to event logger and fire events. // Output to event logger and fire events.
if (!s.ok() || meta->fd.GetFileSize() > 0) { EventHelpers::LogAndNotifyTableFileCreationFinished(
EventHelpers::LogAndNotifyTableFileCreationFinished( event_logger, ioptions.listeners, dbname, column_family_name, fname,
event_logger, ioptions.listeners, dbname, column_family_name, fname, job_id, meta->fd, tp, reason, s);
job_id, meta->fd, tp, reason, s);
}
return s; return s;
} }