andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix db_bench memory use after free (detected by clang_analyze)

Browse Source 
Summary: Fix using `arg[i].thread` after deleting it

Test Plan: run clang_analyze

Subscribers: andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D63171
This commit is contained in:
Islam AbdelRahman 2016-09-02 10:58:08 -07:00
parent 4fd08f4b8b
commit 5051755e35
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/db_bench_tool.cc
View File

@ -2460,11 +2460,6 @@ class Benchmark {
} }
shared.mu.Unlock(); shared.mu.Unlock();
for (int i = 0; i < n; i++) {
delete arg[i].thread;
}
delete[] arg;
// Stats for some threads can be excluded. // Stats for some threads can be excluded.
Stats merge_stats; Stats merge_stats;
for (int i = 0; i < n; i++) { for (int i = 0; i < n; i++) {
@ -2472,6 +2467,11 @@ class Benchmark {
} }
merge_stats.Report(name); merge_stats.Report(name);
for (int i = 0; i < n; i++) {
delete arg[i].thread;
}
delete[] arg;
return merge_stats; return merge_stats;
} }