From 521724ba8279df153ceb96eeba30a76904687853 Mon Sep 17 00:00:00 2001 From: jsteemann Date: Fri, 23 Jun 2017 09:32:11 -0700 Subject: [PATCH] fixed wrong type for "allow_compaction" parameter Summary: should be boolean, not uint64_t MSVC complains about it during compilation with error `include\rocksdb\advanced_options.h(77): warning C4800: 'uint64_t': forcing value to bool 'true' or 'false' (performance warning)` Closes https://github.com/facebook/rocksdb/pull/2487 Differential Revision: D5310685 Pulled By: siying fbshipit-source-id: 719a33b3dba4f711aa72e3f229013c188015dc86 --- include/rocksdb/advanced_options.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rocksdb/advanced_options.h b/include/rocksdb/advanced_options.h index 392ecbe18..1e2714836 100644 --- a/include/rocksdb/advanced_options.h +++ b/include/rocksdb/advanced_options.h @@ -72,7 +72,7 @@ struct CompactionOptionsFIFO { CompactionOptionsFIFO() : max_table_files_size(1 * 1024 * 1024 * 1024) {} CompactionOptionsFIFO(uint64_t _max_table_files_size, - uint64_t _allow_compaction) + bool _allow_compaction) : max_table_files_size(_max_table_files_size), allow_compaction(_allow_compaction) {} };