andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix stats_history_test failure on Windows (#8520)

Browse Source 
Summary:
Fixed a stats_history_test failure on Windows
* In StatsHistoryTest.InMemoryStatsHistoryPurging test, the capping memory cost of stats_history_size on Windows increases to 15000 bytes with latest changes

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8520

Reviewed By: ajkr

Differential Revision: D29734631

Pulled By: mrambacher

fbshipit-source-id: 461698fcf22ef06acfb7f7aa86f8415aaffe7f1e
This commit is contained in:
sherriiiliu 2021-07-19 10:33:59 -07:00 committed by Facebook GitHub Bot
parent d5f3b77f23
commit 5535d06b9c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
monitoring/stats_history_test.cc
View File

@ -245,10 +245,10 @@ TEST_F(StatsHistoryTest, InMemoryStatsHistoryPurging) {
} }
size_t stats_history_size = dbfull()->TEST_EstimateInMemoryStatsHistorySize(); size_t stats_history_size = dbfull()->TEST_EstimateInMemoryStatsHistorySize();
ASSERT_GE(slice_count, kIterations - 1); ASSERT_GE(slice_count, kIterations - 1);
ASSERT_GE(stats_history_size, 14000); ASSERT_GE(stats_history_size, 15000);
// capping memory cost at 14000 bytes since one slice is around 10000~14000 // capping memory cost at 15000 bytes since one slice is around 10000~15000
ASSERT_OK(dbfull()->SetDBOptions({{"stats_history_buffer_size", "14000"}})); ASSERT_OK(dbfull()->SetDBOptions({{"stats_history_buffer_size", "15000"}}));
ASSERT_EQ(14000, dbfull()->GetDBOptions().stats_history_buffer_size); ASSERT_EQ(15000, dbfull()->GetDBOptions().stats_history_buffer_size);
// Wait for stats persist to finish // Wait for stats persist to finish
for (int i = 0; i < kIterations; ++i) { for (int i = 0; i < kIterations; ++i) {
@ -270,7 +270,7 @@ TEST_F(StatsHistoryTest, InMemoryStatsHistoryPurging) {
dbfull()->TEST_EstimateInMemoryStatsHistorySize(); dbfull()->TEST_EstimateInMemoryStatsHistorySize();
// only one slice can fit under the new stats_history_buffer_size // only one slice can fit under the new stats_history_buffer_size
ASSERT_LT(slice_count, 2); ASSERT_LT(slice_count, 2);
ASSERT_TRUE(stats_history_size_reopen < 13000 && ASSERT_TRUE(stats_history_size_reopen < 15000 &&
stats_history_size_reopen > 0); stats_history_size_reopen > 0);
ASSERT_TRUE(stats_count_reopen < stats_count && stats_count_reopen > 0); ASSERT_TRUE(stats_count_reopen < stats_count && stats_count_reopen > 0);
Close(); Close();