From 55e03b67df735d17006d5a17134d98c42f215ed8 Mon Sep 17 00:00:00 2001 From: Sagar Vemuri Date: Tue, 15 Jan 2019 16:25:03 -0800 Subject: [PATCH] Correct the comment about inlined blob option (#4887) Summary: - Corrected a comment asserting that the values "smaller" than a min_blob_size will be inlined in the base db. - Also fixed the type of ttl_range_secs while dumping blobdb options. Pull Request resolved: https://github.com/facebook/rocksdb/pull/4887 Differential Revision: D13680163 Pulled By: sagar0 fbshipit-source-id: 306c8cf2daa52210ffc334a6924ef44ffdedf887 --- utilities/blob_db/blob_db.cc | 2 +- utilities/blob_db/blob_db.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/blob_db/blob_db.cc b/utilities/blob_db/blob_db.cc index b5948cd62..9e4e61741 100644 --- a/utilities/blob_db/blob_db.cc +++ b/utilities/blob_db/blob_db.cc @@ -76,7 +76,7 @@ void BlobDBOptions::Dump(Logger* log) const { log, " BlobDBOptions.max_db_size: %" PRIu64, max_db_size); ROCKS_LOG_HEADER( - log, " BlobDBOptions.ttl_range_secs: %" PRIu32, + log, " BlobDBOptions.ttl_range_secs: %" PRIu64, ttl_range_secs); ROCKS_LOG_HEADER( log, " BlobDBOptions.min_blob_size: %" PRIu64, diff --git a/utilities/blob_db/blob_db.h b/utilities/blob_db/blob_db.h index 021d52aa8..1eee9fcc3 100644 --- a/utilities/blob_db/blob_db.h +++ b/utilities/blob_db/blob_db.h @@ -52,7 +52,7 @@ struct BlobDBOptions { // and so on uint64_t ttl_range_secs = 3600; - // The smallest value to store in blob log. Value larger than this threshold + // The smallest value to store in blob log. Values smaller than this threshold // will be inlined in base DB together with the key. uint64_t min_blob_size = 0;