andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ldb: set total_order_seek for scans (#5066)

Browse Source 
Summary:
Without `total_order_seek=true`, using this command with `prefix_extractor` set skips over lots of keys.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5066

Differential Revision: D14425967

Pulled By: sagar0

fbshipit-source-id: f6f142733258d92604f920615be9266e1fe797f8
This commit is contained in:
Andrew Kryczka 2019-03-12 13:04:20 -07:00 committed by Facebook Github Bot
parent 8a1ecd1982
commit 5a5c0492db
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/ldb_cmd.cc
View File

@ -1469,7 +1469,9 @@ void DBDumperCommand::DoDumpCommand() {
} }
// Setup key iterator // Setup key iterator
Iterator* iter = db_->NewIterator(ReadOptions(), GetCfHandle()); ReadOptions scan_read_opts;
scan_read_opts.total_order_seek = true;
Iterator* iter = db_->NewIterator(scan_read_opts, GetCfHandle());
Status st = iter->status(); Status st = iter->status();
if (!st.ok()) { if (!st.ok()) {
exec_state_ = exec_state_ =
@ -2325,7 +2327,9 @@ void ScanCommand::DoCommand() {
} }
int num_keys_scanned = 0; int num_keys_scanned = 0;
Iterator* it = db_->NewIterator(ReadOptions(), GetCfHandle()); ReadOptions scan_read_opts;
scan_read_opts.total_order_seek = true;
Iterator* it = db_->NewIterator(scan_read_opts, GetCfHandle());
if (start_key_specified_) { if (start_key_specified_) {
it->Seek(start_key_); it->Seek(start_key_);
} else { } else {