andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable occasionally failing assertion in TestPrefixScan (#6238)

Browse Source 
Summary:
Seeing crash test failures like

db_stress: db_stress_tool/no_batched_ops_stress.cc:271: virtual
rocksdb::Status
rocksdb::NonBatchedOpsStressTest::TestPrefixScan(rocksdb::ThreadState*,
const rocksdb::ReadOptions&, const std::vector<int>&, const
std::vector<long int>&): Assertion `count <=
GetPrefixKeyCount(prefix.ToString(), upper_bound)' failed.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6238

Differential Revision: D19210312

Pulled By: pdillinger

fbshipit-source-id: 4d2c35c38f418b408e01c7ba22adf6983ae67d44
This commit is contained in:
Peter Dillinger 2019-12-21 21:10:31 -08:00 committed by Facebook Github Bot
parent 22fea0ba79
commit 5f559897cf
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
db_stress_tool/no_batched_ops_stress.cc
View File

@ -268,7 +268,12 @@ class NonBatchedOpsStressTest : public StressTest {
iter->Next()) { iter->Next()) {
++count; ++count;
} }
assert(count <= GetPrefixKeyCount(prefix.ToString(), upper_bound));
// FIXME: This was an assertion but was failing on occasion
if (count > GetPrefixKeyCount(prefix.ToString(), upper_bound)) {
fprintf(stdout, "FIXME: count > GetPrefixKeyCount\n");
}
Status s = iter->status(); Status s = iter->status();
if (iter->status().ok()) { if (iter->status().ok()) {
thread->stats.AddPrefixes(1, count); thread->stats.AddPrefixes(1, count);