From 61dbfbb6ceb0f5b5def2ad21ff59e98885b9fe92 Mon Sep 17 00:00:00 2001
From: Gunnar Kudrjavets <gunnarku@fb.com>
Date: Fri, 8 Jul 2016 16:02:29 -0700
Subject: [PATCH] Add release build to RocksDB per-diff/post-commit tests

Summary: To make sure that we'll have additional verification for release builds, define a new category and add `make release` to per-diff/post-commit tests. This should in theory prevent the release MyRocks integration builds breaks from happening.

Test Plan:
- `[p]arc diff --preview`
- Observe the execution in Sandcastle and make sure that release build and tests are executed.

Reviewers: sdong

Reviewed By: sdong

Subscribers: andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D60441
---
 arcanist_util/config/RocksDBCommonHelper.php |  2 +-
 build_tools/error_filter.py                  |  1 +
 build_tools/rocksdb-lego-determinator        | 23 ++++++++++++++++++++
 3 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/arcanist_util/config/RocksDBCommonHelper.php b/arcanist_util/config/RocksDBCommonHelper.php
index 072f3f64f..087272b82 100644
--- a/arcanist_util/config/RocksDBCommonHelper.php
+++ b/arcanist_util/config/RocksDBCommonHelper.php
@@ -224,7 +224,7 @@ function getSandcastleConfig() {
     // Manually list of tests we want to run in Sandcastle.
     $tests = array(
       "unit", "unit_481", "clang_unit", "tsan", "asan", "lite_test",
-      "valgrind"
+      "valgrind", "release"
     );
   }
 
diff --git a/build_tools/error_filter.py b/build_tools/error_filter.py
index f9d177eed..966c0c5f1 100644
--- a/build_tools/error_filter.py
+++ b/build_tools/error_filter.py
@@ -117,6 +117,7 @@ class TsanErrorParser(MatchErrorParser):
 _TEST_NAME_TO_PARSERS = {
     'punit': [CompilerErrorParser, GTestErrorParser],
     'unit': [CompilerErrorParser, GTestErrorParser],
+    'release': [CompilerErrorParser, GTestErrorParser],
     'unit_481': [CompilerErrorParser, GTestErrorParser],
     'clang_unit': [CompilerErrorParser, GTestErrorParser],
     'clang_analyze': [CompilerErrorParser, ScanBuildErrorParser],
diff --git a/build_tools/rocksdb-lego-determinator b/build_tools/rocksdb-lego-determinator
index 2cfa74383..3c493172c 100755
--- a/build_tools/rocksdb-lego-determinator
+++ b/build_tools/rocksdb-lego-determinator
@@ -146,6 +146,26 @@ UNIT_TEST_COMMANDS="[
     }
 ]"
 
+#
+# RocksDB release build and unit tests
+#
+RELEASE_UNIT_TEST_COMMANDS="[
+    {
+        'name':'Rocksdb Release Unit Test',
+        'oncall':'$ONCALL',
+        'steps': [
+            $CLEANUP_ENV,
+            {
+                'name':'Build and test RocksDB debug version',
+                'shell':'$SHM $DEBUG make J=1 release',
+                'user':'root',
+                $PARSER
+            },
+        ],
+        $REPORT
+    }
+]"
+
 #
 # RocksDB unit test on gcc-4.8.1
 #
@@ -665,6 +685,9 @@ case $1 in
   unit)
     echo $UNIT_TEST_COMMANDS
     ;;
+  release)
+    echo $RELEASE_UNIT_TEST_COMMANDS
+    ;;
   unit_481)
     echo $UNIT_TEST_COMMANDS_481
     ;;