From 67adc937b6f0f552ad8bfc0adbf14c3ea0a8e8fb Mon Sep 17 00:00:00 2001 From: Daniel Black Date: Tue, 13 Dec 2016 14:21:05 -0800 Subject: [PATCH] intentional fallthough (prevents gcc-7/clang-4 error) Summary: db/memtable.cc: In member function 'void rocksdb::MemTable::Update(rocksdb::SequenceNumber, const rocksdb::Slice&, const rocksdb::Slice&)': db/memtable.cc:736:11: error: this statement may fall through [-Werror=implicit-fallthrough=] } ^ db/memtable.cc:738:9: note: here default: ^~~~~~~ cc1plus: all warnings being treated as errors closes #1650 Closes https://github.com/facebook/rocksdb/pull/1655 Differential Revision: D4318696 Pulled By: yiwu-arbug fbshipit-source-id: 1a8981c --- db/memtable.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/db/memtable.cc b/db/memtable.cc index ca3545fba..93c97bb9b 100644 --- a/db/memtable.cc +++ b/db/memtable.cc @@ -735,6 +735,7 @@ void MemTable::Update(SequenceNumber seq, return; } } + // fallthrough default: // If the latest value is kTypeDeletion, kTypeMerge or kTypeLogData // we don't have enough space for update inplace