From 6a4ec41fedf348fff45eb2afe6d43fdb70e2f252 Mon Sep 17 00:00:00 2001 From: Zhongyi Xie Date: Fri, 11 Jan 2019 12:02:47 -0800 Subject: [PATCH] add assert to silence clang warning (#4871) Summary: currently clang analyze fails with the following warning: > utilities/transactions/write_prepared_transaction_test.cc:1451:5: warning: Forming reference to null pointer ASSERT_GT(wp_db->max_evicted_seq_, 0); // max after recovery Pull Request resolved: https://github.com/facebook/rocksdb/pull/4871 Differential Revision: D13638053 Pulled By: miasantreble fbshipit-source-id: b192b0c13c411c58defc9e280b34cdfcab3fa8e3 --- utilities/transactions/write_prepared_transaction_test.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/utilities/transactions/write_prepared_transaction_test.cc b/utilities/transactions/write_prepared_transaction_test.cc index 007b9ccd4..6e3895d84 100644 --- a/utilities/transactions/write_prepared_transaction_test.cc +++ b/utilities/transactions/write_prepared_transaction_test.cc @@ -1448,6 +1448,7 @@ TEST_P(WritePreparedTransactionTest, IsInSnapshotEmptyMapTest) { db_impl->FlushWAL(true); ReOpenNoDelete(); WritePreparedTxnDB* wp_db = dynamic_cast(db); + assert(wp_db != nullptr); ASSERT_GT(wp_db->max_evicted_seq_, 0); // max after recovery // Take a snapshot right after recovery const Snapshot* snap = db->GetSnapshot();