andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable BasicLockEscalation if cannot determine whether TSAN is enabled (#7814)

Browse Source 
Summary:
BasicLockEscalation will cause false-positive warnings under TSAN (this is a known issue in TSAN, see details in https://gist.github.com/spetrunia/77274cf2d5848e0a7e090d622695ed4e), skip this test if TSAN is enabled, or if we are not sure whether TSAN is enabled.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7814

Test Plan: watch the tsan contrun test to pass.

Reviewed By: zhichao-cao

Differential Revision: D25708094

Pulled By: cheng-chang

fbshipit-source-id: 4fc813ff373301d033d086154cc7bb60a5e95889
This commit is contained in:
cheng-chang 2020-12-27 16:16:55 -08:00 committed by Facebook GitHub Bot
parent 44ebc24dca
commit 736c6dc59f
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
utilities/transactions/lock/range/range_locking_test.cc
View File

@ -220,6 +220,8 @@ TEST_F(RangeLockingTest, MultipleTrxLockStatusData) {
#if __has_feature(thread_sanitizer) #if __has_feature(thread_sanitizer)
#define SKIP_LOCK_ESCALATION_TEST 1 #define SKIP_LOCK_ESCALATION_TEST 1
#endif #endif
#else
#define SKIP_LOCK_ESCALATION_TEST 1
#endif #endif
#ifndef SKIP_LOCK_ESCALATION_TEST #ifndef SKIP_LOCK_ESCALATION_TEST