andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix potential memory leak (#7245)

Browse Source 
Summary:
```
int* value = new int;
ASSERT_NE(nullptr, value);
```
`ASSERT_NE` can expand the expression such that a memory leak is
reported by clang analyzer.
We can remove this ASSERT_NE since we can assume the memory allocation
must succeed. Otherwise a bad alloc exception will be thrown and the
process will be killed anyway.

Test plan (dev server):
```
USE_CLANG=1 make analyze
```

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7245

Reviewed By: jay-zhuang

Differential Revision: D23079641

Pulled By: riversand963

fbshipit-source-id: a6739a903f90f8715f6f1ef3e5c8a329245b8e78
This commit is contained in:
Yanqin Jin 2020-08-12 12:01:42 -07:00 committed by Facebook GitHub Bot
parent 378bc94d7e
commit 76609cd38a
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/timer_test.cc
View File

@ -289,7 +289,6 @@ TEST_F(TimerTest, CancelRunningTask) {
Timer timer(mock_env_.get()); Timer timer(mock_env_.get());
ASSERT_TRUE(timer.Start()); ASSERT_TRUE(timer.Start());
int* value = new int; int* value = new int;
ASSERT_NE(nullptr, value); // make linter happy
*value = 0; *value = 0;
SyncPoint::GetInstance()->DisableProcessing(); SyncPoint::GetInstance()->DisableProcessing();
SyncPoint::GetInstance()->LoadDependency({ SyncPoint::GetInstance()->LoadDependency({
@ -337,7 +336,6 @@ TEST_F(TimerTest, ShutdownRunningTask) {
ASSERT_TRUE(timer.Start()); ASSERT_TRUE(timer.Start());
int* value = new int; int* value = new int;
ASSERT_NE(nullptr, value);
*value = 0; *value = 0;
timer.Add( timer.Add(
[&]() { [&]() {