andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Skip write_prepared_transaction_test in travis

Browse Source 
Summary:
The patch skips write_prepared_transaction_test from travis as they time out there. They are still covered in daily runs of tests.
Closes https://github.com/facebook/rocksdb/pull/2836

Differential Revision: D5767203

Pulled By: maysamyabandeh

fbshipit-source-id: 51045ef98a745197136e14b2ec02fc6f38081b75
This commit is contained in:
Maysam Yabandeh 2017-09-05 15:28:29 -07:00 committed by Facebook Github Bot
parent ab95e293d2
commit 79810e2d49
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
utilities/transactions/write_prepared_transaction_test.cc
View File

@ -341,6 +341,8 @@ TEST_P(WritePreparedTransactionTest, CheckAgainstSnapshotsTest) {
// Return true if the ith bit is set in combination represented by comb // Return true if the ith bit is set in combination represented by comb
bool IsInCombination(size_t i, size_t comb) { return comb & (size_t(1) << i); } bool IsInCombination(size_t i, size_t comb) { return comb & (size_t(1) << i); }
// This test is too slow for travis
#ifndef TRAVIS
// Test that CheckAgainstSnapshots will not miss a live snapshot if it is run in // Test that CheckAgainstSnapshots will not miss a live snapshot if it is run in
// parallel with UpdateSnapshots. // parallel with UpdateSnapshots.
TEST_P(WritePreparedTransactionTest, SnapshotConcurrentAccessTest) { TEST_P(WritePreparedTransactionTest, SnapshotConcurrentAccessTest) {
@ -362,8 +364,6 @@ TEST_P(WritePreparedTransactionTest, SnapshotConcurrentAccessTest) {
for (size_t old_size = 1; for (size_t old_size = 1;
old_size <= WritePreparedTxnDB::DEF_SNAPSHOT_CACHE_SIZE + 2; old_size <= WritePreparedTxnDB::DEF_SNAPSHOT_CACHE_SIZE + 2;
old_size++) { old_size++) {
printf("."); // To signal progress
fflush(stdout);
const std::vector<SequenceNumber> old_snapshots( const std::vector<SequenceNumber> old_snapshots(
snapshots.begin(), snapshots.begin() + old_size); snapshots.begin(), snapshots.begin() + old_size);
@ -371,6 +371,8 @@ TEST_P(WritePreparedTransactionTest, SnapshotConcurrentAccessTest) {
// create a common_snapshots for each combination. // create a common_snapshots for each combination.
size_t new_comb_cnt = size_t(1) << old_size; size_t new_comb_cnt = size_t(1) << old_size;
for (size_t new_comb = 0; new_comb < new_comb_cnt; new_comb++) { for (size_t new_comb = 0; new_comb < new_comb_cnt; new_comb++) {
printf("."); // To signal progress
fflush(stdout);
std::vector<SequenceNumber> common_snapshots; std::vector<SequenceNumber> common_snapshots;
for (size_t i = 0; i < old_snapshots.size(); i++) { for (size_t i = 0; i < old_snapshots.size(); i++) {
if (IsInCombination(i, new_comb)) { if (IsInCombination(i, new_comb)) {
@ -419,6 +421,7 @@ TEST_P(WritePreparedTransactionTest, SnapshotConcurrentAccessTest) {
} }
} }
} }
#endif
// Test WritePreparedTxnDB's IsInSnapshot against different ordering of // Test WritePreparedTxnDB's IsInSnapshot against different ordering of
// snapshot, max_committed_seq_, prepared, and commit entries. // snapshot, max_committed_seq_, prepared, and commit entries.