andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

BlobDB: Remove GC interval option (#5044)

Browse Source 
Summary:
Remove BlobDBOptions.garbage_collection_interval_secs for now, since
garbage collection is not yet implemented in BlobDB.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5044

Differential Revision: D14354046

Pulled By: ltamasi

fbshipit-source-id: 2b966b6d1e088ba9462f3ea73e115013562fbc04
This commit is contained in:
Levi Tamasi 2019-03-07 10:15:24 -08:00 committed by Facebook Github Bot
parent 04a2631dbe
commit 79b6ab43ce
3 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
utilities/blob_db/blob_db.cc
View File

@ -93,9 +93,6 @@ void BlobDBOptions::Dump(Logger* log) const {
ROCKS_LOG_HEADER( ROCKS_LOG_HEADER(
log, " BlobDBOptions.enable_garbage_collection: %d", log, " BlobDBOptions.enable_garbage_collection: %d",
enable_garbage_collection); enable_garbage_collection);
ROCKS_LOG_HEADER(
log, " BlobDBOptions.garbage_collection_interval_secs: %" PRIu64,
garbage_collection_interval_secs);
ROCKS_LOG_HEADER( ROCKS_LOG_HEADER(
log, " BlobDBOptions.disable_background_tasks: %d", log, " BlobDBOptions.disable_background_tasks: %d",
disable_background_tasks); disable_background_tasks);

3
utilities/blob_db/blob_db.h
View File

@ -73,9 +73,6 @@ struct BlobDBOptions {
// blob files will be cleanup based on TTL. // blob files will be cleanup based on TTL.
bool enable_garbage_collection = false; bool enable_garbage_collection = false;
// Time interval to trigger garbage collection, in seconds.
uint64_t garbage_collection_interval_secs = 60;
// Disable all background job. Used for test only. // Disable all background job. Used for test only.
bool disable_background_tasks = false; bool disable_background_tasks = false;

3
utilities/blob_db/blob_db_impl.cc
View File

@ -198,9 +198,6 @@ void BlobDBImpl::StartBackgroundTasks() {
tqueue_.add( tqueue_.add(
kReclaimOpenFilesPeriodMillisecs, kReclaimOpenFilesPeriodMillisecs,
std::bind(&BlobDBImpl::ReclaimOpenFiles, this, std::placeholders::_1)); std::bind(&BlobDBImpl::ReclaimOpenFiles, this, std::placeholders::_1));
tqueue_.add(static_cast<int64_t>(
bdb_options_.garbage_collection_interval_secs * 1000),
std::bind(&BlobDBImpl::RunGC, this, std::placeholders::_1));
tqueue_.add( tqueue_.add(
kDeleteObsoleteFilesPeriodMillisecs, kDeleteObsoleteFilesPeriodMillisecs,
std::bind(&BlobDBImpl::DeleteObsoleteFiles, this, std::placeholders::_1)); std::bind(&BlobDBImpl::DeleteObsoleteFiles, this, std::placeholders::_1));