andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

db_stress: wait for compaction to finish after open with failure injection (#8270)

Browse Source 
Summary:
When injecting in DB open, error can happen in background threads, causing DB open succeed, but DB is soon made read-only and subsequence writes will fail, which is not expected. To prevent it from happening, wait for compaction to finish before serving the traffic. If there is a failure, reopen.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8270

Test Plan: Run the test.

Reviewed By: ajkr

Differential Revision: D28230537

fbshipit-source-id: e2e97888904f9b9bb50c35ccf95b88c2319ef5c3
This commit is contained in:
sdong 2021-05-05 16:40:45 -07:00 committed by Facebook GitHub Bot
parent e19908cba6
commit 7f3a0f5bc6
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
db_stress_tool/db_stress_test_base.cc
View File

@ -2468,6 +2468,16 @@ void StressTest::Open() {
#ifndef NDEBUG #ifndef NDEBUG
if (ingest_meta_error) { if (ingest_meta_error) {
fault_fs_guard->DisableMetadataWriteErrorInjection(); fault_fs_guard->DisableMetadataWriteErrorInjection();
if (s.ok()) {
// Ingested errors might happen in background compactions. We
// wait for all compactions to finish to make sure DB is in
// clean state before executing queries.
s = static_cast_with_check<DBImpl>(db_->GetRootDB())
->TEST_WaitForCompact(true);
if (!s.ok()) {
delete db_;
}
}
if (!s.ok()) { if (!s.ok()) {
// After failure to opening a DB due to IO error, retry should // After failure to opening a DB due to IO error, retry should
// successfully open the DB with correct data if no IO error shows // successfully open the DB with correct data if no IO error shows