andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove 'ALIGNAS' from StatisticsImpl. (#4061)

Browse Source 
Summary:
Remove over-alignment on `StatisticsImpl` whose benefit is vague and causes UBSAN check to fail due to `std::make_shared` not respecting the over-alignment requirement.

Test plan
```
$ make clean && COMPILE_WITH_UBSAN=1 OPT=-g make -j16 ubsan_check
```
Closes https://github.com/facebook/rocksdb/pull/4061

Differential Revision: D8656506

Pulled By: riversand963

fbshipit-source-id: db355ae9c7bdd2c9e9c5e63cabba13d8d82cc5f9
This commit is contained in:
Yanqin Jin 2018-06-27 20:55:07 -07:00 committed by Facebook Github Bot
parent 14f409c0f1
commit 7f850b889d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
monitoring/statistics.h
View File

@ -40,7 +40,7 @@ enum HistogramsInternal : uint32_t {
};
class ALIGN_AS(CACHE_LINE_SIZE) StatisticsImpl : public Statistics {
class StatisticsImpl : public Statistics {
public:
StatisticsImpl(std::shared_ptr<Statistics> stats,
bool enable_internal_stats);