andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable DBIOFailureTest.NoSpaceCompactRange in LITE (#4596)

Browse Source 
Summary:
Since ErrorHandler::RecoverFromNoSpace is no-op in LITE mode, then we should
not have this test in LITE mode. If we do keep it, it will cause the test
thread to wait on bg_cv_ that will not be signalled.

How to reproduce
```
$make clean && git checkout a27fce408e
$OPT="-DROCKSDB_LITE -g" make -j20
$./db_io_failure_test --gtest_filter=DBIOFailureTest.NoSpaceCompactRange
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4596

Differential Revision: D12818516

Pulled By: riversand963

fbshipit-source-id: bc83524f40fff1e29506979017f7f4c2b70322f3
This commit is contained in:
Yanqin Jin 2018-10-29 14:34:12 -07:00 committed by Facebook Github Bot
parent 7fb39f1ae1
commit 806ff34b61
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
db/db_io_failure_test.cc
View File

@ -88,7 +88,6 @@ TEST_F(DBIOFailureTest, DropWritesFlush) {
env_->drop_writes_.store(false, std::memory_order_release); env_->drop_writes_.store(false, std::memory_order_release);
} while (ChangeCompactOptions()); } while (ChangeCompactOptions());
} }
#endif // ROCKSDB_LITE
// Check that CompactRange() returns failure if there is not enough space left // Check that CompactRange() returns failure if there is not enough space left
// on device // on device
@ -116,6 +115,7 @@ TEST_F(DBIOFailureTest, NoSpaceCompactRange) {
env_->no_space_.store(false, std::memory_order_release); env_->no_space_.store(false, std::memory_order_release);
} while (ChangeCompactOptions()); } while (ChangeCompactOptions());
} }
#endif // ROCKSDB_LITE
TEST_F(DBIOFailureTest, NonWritableFileSystem) { TEST_F(DBIOFailureTest, NonWritableFileSystem) {
do { do {