andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use int64_t instead of ssize_t (#5638)

Browse Source 
Summary:
The ssize_t type was introduced in https://github.com/facebook/rocksdb/pull/5633, but it seems like it's a POSIX specific type.

I just need a signed type to represent number of bytes, so use int64_t instead. It seems like we have a typedef from SSIZE_T for Windows, but it doesn't seem like we ever include "port/port.h" in our public header files.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5638

Differential Revision: D16526269

Pulled By: lth

fbshipit-source-id: 8d3a5c41003951b74b29bc5f1d949b2b22da0cee
This commit is contained in:
Manuel Ung 2019-07-26 16:28:38 -07:00 committed by Facebook Github Bot
parent 3f89af1c39
commit 80d7067cb2
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/rocksdb/utilities/transaction_db.h
View File

@ -104,7 +104,7 @@ struct TransactionDBOptions {
// This option is only valid for write unprepared. If a write batch exceeds // This option is only valid for write unprepared. If a write batch exceeds
// this threshold, then the transaction will implicitly flush the currently // this threshold, then the transaction will implicitly flush the currently
// pending writes into the database. A value of 0 or less means no limit. // pending writes into the database. A value of 0 or less means no limit.
ssize_t default_write_batch_flush_threshold = 0; int64_t default_write_batch_flush_threshold = 0;
private: private:
// 128 entries // 128 entries
@ -171,7 +171,7 @@ struct TransactionOptions {
// See TransactionDBOptions::default_write_batch_flush_threshold for // See TransactionDBOptions::default_write_batch_flush_threshold for
// description. If a negative value is specified, then the default value from // description. If a negative value is specified, then the default value from
// TransactionDBOptions is used. // TransactionDBOptions is used.
ssize_t write_batch_flush_threshold = -1; int64_t write_batch_flush_threshold = -1;
}; };
// The per-write optimizations that do not involve transactions. TransactionDB // The per-write optimizations that do not involve transactions. TransactionDB

2
utilities/transactions/write_unprepared_txn.h
View File

@ -167,7 +167,7 @@ class WriteUnpreparedTxn : public WritePreparedTxn {
// write_batch_flush_threshold_ has been exceeded, and then call // write_batch_flush_threshold_ has been exceeded, and then call
// FlushWriteBatchToDB if so. This logic is encapsulated in // FlushWriteBatchToDB if so. This logic is encapsulated in
// MaybeFlushWriteBatchToDB. // MaybeFlushWriteBatchToDB.
ssize_t write_batch_flush_threshold_; int64_t write_batch_flush_threshold_;
WriteUnpreparedTxnDB* wupt_db_; WriteUnpreparedTxnDB* wupt_db_;
// Ordered list of unprep_seq sequence numbers that we have already written // Ordered list of unprep_seq sequence numbers that we have already written