andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix Windows build in block_cache_tracer_test (#7795)

Browse Source 
Summary:
The test was added to cmake in https://github.com/facebook/rocksdb/issues/7783

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7795

Reviewed By: akankshamahajan15

Differential Revision: D25671010

Pulled By: jay-zhuang

fbshipit-source-id: 2146ff9559cdd7266c4d78476672488c62654a6d
This commit is contained in:
Jay Zhuang 2020-12-21 15:20:59 -08:00 committed by Facebook GitHub Bot
parent fd0d35d390
commit 861b0d1a49
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
trace_replay/block_cache_tracer_test.cc
View File

@ -52,6 +52,7 @@ class BlockCacheTracerTest : public testing::Test {
return TableReaderCaller::kUserIterator; return TableReaderCaller::kUserIterator;
} }
assert(false); assert(false);
return TableReaderCaller::kMaxBlockCacheLookupCaller;
} }
void WriteBlockAccess(BlockCacheTraceWriter* writer, uint32_t from_key_id, void WriteBlockAccess(BlockCacheTraceWriter* writer, uint32_t from_key_id,
@ -200,8 +201,8 @@ TEST_F(BlockCacheTracerTest, AtomicWrite) {
BlockCacheTraceReader reader(std::move(trace_reader)); BlockCacheTraceReader reader(std::move(trace_reader));
BlockCacheTraceHeader header; BlockCacheTraceHeader header;
ASSERT_OK(reader.ReadHeader(&header)); ASSERT_OK(reader.ReadHeader(&header));
ASSERT_EQ(kMajorVersion, header.rocksdb_major_version); ASSERT_EQ(kMajorVersion, static_cast<int>(header.rocksdb_major_version));
ASSERT_EQ(kMinorVersion, header.rocksdb_minor_version); ASSERT_EQ(kMinorVersion, static_cast<int>(header.rocksdb_minor_version));
VerifyAccess(&reader, 0, TraceType::kBlockTraceDataBlock, 1); VerifyAccess(&reader, 0, TraceType::kBlockTraceDataBlock, 1);
ASSERT_NOK(reader.ReadAccess(&record)); ASSERT_NOK(reader.ReadAccess(&record));
} }
@ -244,8 +245,8 @@ TEST_F(BlockCacheTracerTest, AtomicNoWriteAfterEndTrace) {
BlockCacheTraceReader reader(std::move(trace_reader)); BlockCacheTraceReader reader(std::move(trace_reader));
BlockCacheTraceHeader header; BlockCacheTraceHeader header;
ASSERT_OK(reader.ReadHeader(&header)); ASSERT_OK(reader.ReadHeader(&header));
ASSERT_EQ(kMajorVersion, header.rocksdb_major_version); ASSERT_EQ(kMajorVersion, static_cast<int>(header.rocksdb_major_version));
ASSERT_EQ(kMinorVersion, header.rocksdb_minor_version); ASSERT_EQ(kMinorVersion, static_cast<int>(header.rocksdb_minor_version));
VerifyAccess(&reader, 0, TraceType::kBlockTraceDataBlock, 1); VerifyAccess(&reader, 0, TraceType::kBlockTraceDataBlock, 1);
ASSERT_NOK(reader.ReadAccess(&record)); ASSERT_NOK(reader.ReadAccess(&record));
} }
@ -307,8 +308,8 @@ TEST_F(BlockCacheTracerTest, MixedBlocks) {
BlockCacheTraceReader reader(std::move(trace_reader)); BlockCacheTraceReader reader(std::move(trace_reader));
BlockCacheTraceHeader header; BlockCacheTraceHeader header;
ASSERT_OK(reader.ReadHeader(&header)); ASSERT_OK(reader.ReadHeader(&header));
ASSERT_EQ(kMajorVersion, header.rocksdb_major_version); ASSERT_EQ(kMajorVersion, static_cast<int>(header.rocksdb_major_version));
ASSERT_EQ(kMinorVersion, header.rocksdb_minor_version); ASSERT_EQ(kMinorVersion, static_cast<int>(header.rocksdb_minor_version));
// Read blocks. // Read blocks.
VerifyAccess(&reader, 0, TraceType::kBlockTraceUncompressionDictBlock, 10); VerifyAccess(&reader, 0, TraceType::kBlockTraceUncompressionDictBlock, 10);
VerifyAccess(&reader, 10, TraceType::kBlockTraceDataBlock, 10); VerifyAccess(&reader, 10, TraceType::kBlockTraceDataBlock, 10);