andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

disable rate limiter test

Browse Source 
Summary:
The test is not stable because it relies on disk and only runs for a
short period of time. So misisng a compaction/flush would greatly affect
the rate. I am disabling it for now. What do you guys think?

Test Plan: make

Reviewers: yhchiang, igor, sdong

Reviewed By: sdong

Subscribers: leveldb

Differential Revision: https://reviews.facebook.net/D19599
This commit is contained in:
Lei Jin 2014-07-09 22:46:15 -07:00
parent f697cad15c
commit 8a7d1fe616
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
db/db_test.cc
View File

@ -7133,6 +7133,9 @@ TEST(DBTest, MTRandomTimeoutTest) {
} // anonymous namespace } // anonymous namespace
/*
* This test is not reliable enough as it heavily depends on disk behavior.
*
TEST(DBTest, RateLimitingTest) { TEST(DBTest, RateLimitingTest) {
Options options = CurrentOptions(); Options options = CurrentOptions();
options.write_buffer_size = 1 << 20; // 1MB options.write_buffer_size = 1 << 20; // 1MB
@ -7201,6 +7204,7 @@ TEST(DBTest, RateLimitingTest) {
fprintf(stderr, "write rate ratio = %.2lf, expected 0.5\n", ratio); fprintf(stderr, "write rate ratio = %.2lf, expected 0.5\n", ratio);
ASSERT_TRUE(ratio > 0.4 && ratio < 0.6); ASSERT_TRUE(ratio > 0.4 && ratio < 0.6);
} }
*/
} // namespace rocksdb } // namespace rocksdb