andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix copy constructors of Options and ColumnFamilyOptions (#9166)

Browse Source 
Summary:
Looks like some fields are not copied by the copy constructor.

Please confirm if it is a real issue!

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9166

Reviewed By: jay-zhuang

Differential Revision: D32532093

Pulled By: mrambacher

fbshipit-source-id: f636ef9425a530a8655947115160ae471916252b
This commit is contained in:
Davide Angelocola 2021-12-13 07:21:54 -08:00 committed by Facebook GitHub Bot
parent eca85cdb66
commit 8a97c541e4
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
java/src/main/java/org/rocksdb/ColumnFamilyOptions.java
View File

@ -52,6 +52,7 @@ public class ColumnFamilyOptions extends RocksObject
this.bottommostCompressionOptions_ = other.bottommostCompressionOptions_; this.bottommostCompressionOptions_ = other.bottommostCompressionOptions_;
this.compressionOptions_ = other.compressionOptions_; this.compressionOptions_ = other.compressionOptions_;
this.compactionThreadLimiter_ = other.compactionThreadLimiter_; this.compactionThreadLimiter_ = other.compactionThreadLimiter_;
this.sstPartitionerFactory_ = other.sstPartitionerFactory_;
} }
/** /**

3
java/src/main/java/org/rocksdb/Options.java
View File

@ -92,6 +92,9 @@ public class Options extends RocksObject
this.rowCache_ = other.rowCache_; this.rowCache_ = other.rowCache_;
this.writeBufferManager_ = other.writeBufferManager_; this.writeBufferManager_ = other.writeBufferManager_;
this.compactionThreadLimiter_ = other.compactionThreadLimiter_; this.compactionThreadLimiter_ = other.compactionThreadLimiter_;
this.bottommostCompressionOptions_ = other.bottommostCompressionOptions_;
this.walFilter_ = other.walFilter_;
this.sstPartitionerFactory_ = other.sstPartitionerFactory_;
} }
@Override @Override