andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix the build and test bugs in the Trace_analyzer (#4274)

Browse Source 
Summary:
The wrong options are used in the trace_analyzer_test, removed. The potential loses integer precision are fixed.

Pass the specified testing case, make asan_check
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4274

Reviewed By: yiwu-arbug

Differential Revision: D9327811

Pulled By: zhichao-cao

fbshipit-source-id: d62cb18d6586503a490cd323bfc1c672b68b346e
This commit is contained in:
Zhichao Cao 2018-08-14 18:19:25 -07:00 committed by Facebook Github Bot
parent 33ad9060d3
commit 8ae2bf5331
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/trace_analyzer_test.cc
View File

@ -55,8 +55,6 @@ class TraceAnalyzerTest : public testing::Test {
void GenerateTrace(std::string trace_path) { void GenerateTrace(std::string trace_path) {
Options options; Options options;
options.create_if_missing = true; options.create_if_missing = true;
options.IncreaseParallelism();
options.OptimizeLevelStyleCompaction();
options.merge_operator = MergeOperators::CreatePutOperator(); options.merge_operator = MergeOperators::CreatePutOperator();
ReadOptions ro; ReadOptions ro;
WriteOptions wo; WriteOptions wo;

4
tools/trace_analyzer_tool.cc
View File

@ -740,7 +740,7 @@ Status TraceAnalyzer::MakeStatisticCorrelation(TraceStats& stats,
// Process the statistics of QPS // Process the statistics of QPS
Status TraceAnalyzer::MakeStatisticQPS() { Status TraceAnalyzer::MakeStatisticQPS() {
uint32_t duration = (end_time_ - begin_time_) / 1000000; uint32_t duration = static_cast<uint32_t>((end_time_ - begin_time_) / 1000000);
int ret; int ret;
Status s; Status s;
std::vector<std::vector<uint32_t>> type_qps( std::vector<std::vector<uint32_t>> type_qps(
@ -1098,7 +1098,7 @@ Status TraceAnalyzer::KeyStatsInsertion(const uint32_t& type,
if (ts < begin_time_) { if (ts < begin_time_) {
time_in_sec = 0; time_in_sec = 0;
} else { } else {
time_in_sec = (ts - begin_time_) / 1000000; time_in_sec = static_cast<uint32_t>((ts - begin_time_) / 1000000);
} }
uint64_t dist_value_size = value_size / FLAGS_value_interval; uint64_t dist_value_size = value_size / FLAGS_value_interval;