andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed const fields in copyable classes (#5095)

Browse Source 
Summary:
This fixed the compile error in Clang-8:
```
error: explicitly defaulted copy assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5095

Differential Revision: D14811961

Pulled By: riversand963

fbshipit-source-id: d935d1f85a4e8694dca10033fb5af92d8777eca0
This commit is contained in:
Harry Wong 2019-04-05 15:16:15 -07:00 committed by Facebook Github Bot
parent 59ef2ba559
commit 8d1e52165d
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
utilities/persistent_cache/block_cache_tier.h
View File

@ -100,7 +100,7 @@ class BlockCacheTier : public PersistentCacheTier {
std::string key_;
std::string data_;
const bool signal_ = false; // signal to request processing thread to exit
bool signal_ = false; // signal to request processing thread to exit
};
// entry point for insert thread

10
utilities/persistent_cache/block_cache_tier_file.h
View File

@ -265,11 +265,11 @@ class ThreadedWriter : public Writer {
IO& operator=(const IO&) = default;
size_t Size() const { return sizeof(IO); }
WritableFile* file_ = nullptr; // File to write to
CacheWriteBuffer* const buf_ = nullptr; // buffer to write
uint64_t file_off_ = 0; // file offset
bool signal_ = false; // signal to exit thread loop
std::function<void()> callback_; // Callback on completion
WritableFile* file_ = nullptr; // File to write to
CacheWriteBuffer* buf_ = nullptr; // buffer to write
uint64_t file_off_ = 0; // file offset
bool signal_ = false; // signal to exit thread loop
std::function<void()> callback_; // Callback on completion
};
explicit ThreadedWriter(PersistentCacheTier* const cache, const size_t qdepth,