andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix use of positional args in BUCK rules (#7760)

Browse Source 
Summary:
Prefer to use keyword args rather than positional args for Buck rules. This appears to be the only remaining instance for `custom_unittest`

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7760

Test Plan: Search for other instances of `custom_unittest` without `name`

Reviewed By: cheng-chang

Differential Revision: D25439887

Pulled By: mzlee

fbshipit-source-id: 518c541a5c01207c7b0c1f7322addf5cc4f09f92
This commit is contained in:
Michael Lee 2020-12-09 19:23:06 -08:00 committed by Facebook GitHub Bot
parent 71239908cf
commit 8e2749fd3a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
TARGETS
View File

@ -810,7 +810,7 @@ cpp_binary(
) if not is_opt_mode else None ) if not is_opt_mode else None
custom_unittest( custom_unittest(
"c_test", name = "c_test",
command = [ command = [
native.package_name() + "/buckifier/rocks_test_runner.sh", native.package_name() + "/buckifier/rocks_test_runner.sh",
"$(location :{})".format("c_test_bin"), "$(location :{})".format("c_test_bin"),

2
buckifier/targets_builder.py
View File

@ -90,7 +90,7 @@ cpp_binary(
) if not is_opt_mode else None ) if not is_opt_mode else None
custom_unittest( custom_unittest(
"c_test", name = "c_test",
command = [ command = [
native.package_name() + "/buckifier/rocks_test_runner.sh", native.package_name() + "/buckifier/rocks_test_runner.sh",
"$(location :{})".format("c_test_bin"), "$(location :{})".format("c_test_bin"),