andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove LockFile

Browse Source 
Summary: LockFile is unnecessary in unit test

Test Plan: env_basic_test.cc

Reviewers: andrewkr

Reviewed By: andrewkr

Subscribers: andrewkr, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D60285
This commit is contained in:
Wanning Jiang 2016-07-01 15:28:08 -07:00
parent ff45d1b547
commit 95d96eeeb1
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
util/env_basic_test.cc
View File

@ -231,15 +231,6 @@ TEST_P(EnvBasicTestWithParam, ReadWrite) {
ASSERT_TRUE(rand_file->Read(1000, 5, &result, scratch).ok()); ASSERT_TRUE(rand_file->Read(1000, 5, &result, scratch).ok());
} }
TEST_P(EnvBasicTestWithParam, Locks) {
FileLock* lock;
// only test they return success.
// TODO(andrewkr): verify functionality
ASSERT_OK(env_->LockFile(test_dir_ + "lock_file", &lock));
ASSERT_OK(env_->UnlockFile(lock));
}
TEST_P(EnvBasicTestWithParam, Misc) { TEST_P(EnvBasicTestWithParam, Misc) {
unique_ptr<WritableFile> writable_file; unique_ptr<WritableFile> writable_file;
ASSERT_OK(env_->NewWritableFile(test_dir_ + "/b", &writable_file, soptions_)); ASSERT_OK(env_->NewWritableFile(test_dir_ + "/b", &writable_file, soptions_));

2
utilities/backupable/backupable_db.cc
View File

@ -560,7 +560,7 @@ Status BackupEngineImpl::Initialize() {
{ {
auto s = backup_env_->GetChildren(GetBackupMetaDir(), &backup_meta_files); auto s = backup_env_->GetChildren(GetBackupMetaDir(), &backup_meta_files);
if (!s.ok()) { if (!s.ok()) {
return Status::NotFound("%s not found", GetBackupMetaDir()); return Status::NotFound(GetBackupMetaDir() + " is missing");
} }
} }
// create backups_ structure // create backups_ structure