andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Exclude c_test from buck build opt mode

Browse Source 
Summary: Fix a Facebook internal build

Test Plan: buck build @mode/opt :c_test :c_test_bin (was compilation
failure, now "not found")
buck build @mode/dev :c_test :c_test_bin (still passes)
This commit is contained in:
Peter Dillinger 2020-07-07 08:32:29 -07:00 committed by Andrew Kryczka
parent 0fdd019f62
commit 9912ebe1b5
2 changed files with 38 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
TARGETS
View File

@ -447,6 +447,7 @@ cpp_library(
external_deps = ROCKSDB_EXTERNAL_DEPS, external_deps = ROCKSDB_EXTERNAL_DEPS,
) )
if not is_opt_mode:
cpp_binary( cpp_binary(
name = "c_test_bin", name = "c_test_bin",
srcs = ["db/c_test.c"], srcs = ["db/c_test.c"],
@ -457,6 +458,7 @@ cpp_binary(
deps = [":rocksdb_test_lib"], deps = [":rocksdb_test_lib"],
) )
if not is_opt_mode:
custom_unittest( custom_unittest(
"c_test", "c_test",
command = [ command = [

2
buckifier/targets_builder.py
View File

@ -78,6 +78,7 @@ class TARGETSBuilder(object):
def add_c_test(self): def add_c_test(self):
self.targets_file.write(""" self.targets_file.write("""
if not is_opt_mode:
cpp_binary( cpp_binary(
name = "c_test_bin", name = "c_test_bin",
srcs = ["db/c_test.c"], srcs = ["db/c_test.c"],
@ -88,6 +89,7 @@ cpp_binary(
deps = [":rocksdb_test_lib"], deps = [":rocksdb_test_lib"],
) )
if not is_opt_mode:
custom_unittest( custom_unittest(
"c_test", "c_test",
command = [ command = [