andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix type in shift operation in bloom_test (#5882)

Browse Source 
Summary:
Broken type for shift in PR#5834. Fixing code means fixing
expected values in test.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5882

Test Plan: thisisthetest

Differential Revision: D17746136

Pulled By: pdillinger

fbshipit-source-id: d3c456ed30b433d55fcab6fc7d836940fe3b46b8
This commit is contained in:
Peter Dillinger 2019-10-03 13:17:44 -07:00 committed by Facebook Github Bot
parent cca87d7722
commit 9f54446525
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
util/bloom_test.cc
View File

@ -302,7 +302,7 @@ class FullBloomTest : public testing::Test {
uint64_t result = 0;
for (int i = 0; i < 64; i++) {
if (Matches(Key(i + 12345, buffer))) {
result |= 1 << i;
result |= uint64_t{1} << i;
}
}
return result;
@ -507,15 +507,15 @@ TEST_F(FullBloomTest, RawSchema) {
// Two probes, about 3/4 bits set: ~50% "FP" rate
// One 256-byte cache line.
OpenRaw(cft.ResetWeirdFill(256, 1, 2));
ASSERT_EQ(18446744073675927543ULL, PackedMatches());
ASSERT_EQ(uint64_t{11384799501900898790U}, PackedMatches());
// Two 128-byte cache lines.
OpenRaw(cft.ResetWeirdFill(256, 2, 2));
ASSERT_EQ(18446744073407559151ULL, PackedMatches());
ASSERT_EQ(uint64_t{10157853359773492589U}, PackedMatches());
// Four 64-byte cache lines.
OpenRaw(cft.ResetWeirdFill(256, 4, 2));
ASSERT_EQ(18446744073441107966ULL, PackedMatches());
ASSERT_EQ(uint64_t{7123594913907464682U}, PackedMatches());
}
TEST_F(FullBloomTest, CorruptFilters) {