andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

arena.h: fix Arena::IsInInlineBlock() (#9317)

Browse Source 
Summary:
When I enable hugepage on my box, unit test fails, this PR fixes this issue:

[  FAILED  ] ArenaTest.ApproximateMemoryUsage (1 ms)

memory/arena_test.cc:127: Failure
Value of: arena.IsInInlineBlock()
  Actual: true
Expected: false
arena.IsInInlineBlock() = 1
memory/arena_test.cc:127: Failure
Value of: arena.IsInInlineBlock()
  Actual: true
Expected: false

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9317

Reviewed By: ajkr

Differential Revision: D36219813

fbshipit-source-id: 08d040d9f37ec4c16987e4150c2db876180d163d
This commit is contained in:
leipeng 2022-05-09 12:21:21 -07:00 committed by Facebook GitHub Bot
parent 7b55b50839
commit 9f7968b2ed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
memory/arena.h
View File

@ -78,7 +78,7 @@ class Arena : public Allocator {
size_t BlockSize() const override { return kBlockSize; } size_t BlockSize() const override { return kBlockSize; }
bool IsInInlineBlock() const { bool IsInInlineBlock() const {
return blocks_.empty(); return blocks_.empty() && huge_blocks_.empty();
} }
private: private: