andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unnecessary status check in TableCache::NewIterator

Browse Source 
Summary:
While investigating the usage of `new_table_iterator_nanos` perf counter, I saw some code was wrapper around with unnecessary status check ... so removed it.
Closes https://github.com/facebook/rocksdb/pull/3120

Differential Revision: D6229181

Pulled By: sagar0

fbshipit-source-id: f8a44fe67f5a05df94553fdb233b21e54e88cc34
This commit is contained in:
Sagar Vemuri 2017-11-03 14:34:10 -07:00 committed by Facebook Github Bot
parent 4c8f336401
commit a6d8e30c05
1 changed files with 33 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
db/table_cache.cc
View File

@ -180,7 +180,6 @@ InternalIterator* TableCache::NewIterator(
bool create_new_table_reader = false; bool create_new_table_reader = false;
TableReader* table_reader = nullptr; TableReader* table_reader = nullptr;
Cache::Handle* handle = nullptr; Cache::Handle* handle = nullptr;
if (s.ok()) {
if (table_reader_ptr != nullptr) { if (table_reader_ptr != nullptr) {
*table_reader_ptr = nullptr; *table_reader_ptr = nullptr;
} }
@ -222,7 +221,6 @@ InternalIterator* TableCache::NewIterator(
} }
} }
} }
}
InternalIterator* result = nullptr; InternalIterator* result = nullptr;
if (s.ok()) { if (s.ok()) {
if (options.table_filter && if (options.table_filter &&