andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve write_with_callback_test to sync WAL

Browse Source 
Summary: Currently write_with_callback_test does not test with WAL syncing enabled. This addresses that.

Test Plan: write_with_callback_test

Reviewers: anthony

Reviewed By: anthony

Subscribers: leveldb, dhruba, hermanlee4

Differential Revision: https://reviews.facebook.net/D54255
This commit is contained in:
reid horuff 2016-02-16 12:39:55 -08:00
parent 5bcf952a87
commit a7b6f0748a
1 changed files with 139 additions and 136 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
db/write_callback_test.cc
View File

@ -113,12 +113,12 @@ TEST_F(WriteCallbackTest, WriteWithCallbackTest) {
for (auto& allow_parallel : {true, false}) {
for (auto& allow_batching : {true, false}) {
for (auto& enable_WAL : {true, false}) {
for (auto& write_group : write_scenarios) {
Options options;
options.create_if_missing = true;
options.allow_concurrent_memtable_write = allow_parallel;
WriteOptions write_options;
ReadOptions read_options;
DB* db;
DBImpl* db_impl;
@ -224,6 +224,8 @@ TEST_F(WriteCallbackTest, WriteWithCallbackTest) {
}
WriteOptions woptions;
woptions.disableWAL = !enable_WAL;
woptions.sync = enable_WAL;
Status s = db_impl->WriteWithCallback(
woptions, &write_op.write_batch_, &write_op.callback_);
@ -269,6 +271,7 @@ TEST_F(WriteCallbackTest, WriteWithCallbackTest) {
}
}
}
}
}
TEST_F(WriteCallbackTest, WriteCallBackTest) {