Improve comment in compaction.h and compaction_picker.h

Summary:
ReleaseCompactionFiles must be called when DB mutex is held,
but the documentation is mission.

Test Plan: no code change

Reviewers: anthony, IslamAbdelRahman, kradhakrishnan, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D54987
This commit is contained in:
Yueh-Hsuan Chiang 2016-03-08 16:46:41 -08:00
parent 2200295ee1
commit aa3f02d50c
2 changed files with 4 additions and 0 deletions

View File

@ -138,6 +138,8 @@ class Compaction {
// Clear all files to indicate that they are not being compacted
// Delete this compaction from the list of running compactions.
//
// Requirement: DB mutex held
void ReleaseCompactionFiles(Status status);
// Returns the summary of the compaction in "output" with maximum "len"

View File

@ -83,6 +83,8 @@ class CompactionPicker {
#endif // ROCKSDB_LITE
// Free up the files that participated in a compaction
//
// Requirement: DB mutex held
void ReleaseCompactionFiles(Compaction* c, Status status);
// Returns true if any one of the specified files are being compacted