andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

crash_test to trigger some less frequent crash point more frequently

Browse Source 
Summary: crash_test still has a very low chance to hit some crash point. Have another mode for covering them more likely.

Test Plan: Run crash_test and see db_stress is called with expected prameters.

Reviewers: kradhakrishnan, igor, anthony, rven, IslamAbdelRahman, yhchiang

Reviewed By: yhchiang

Subscribers: leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D49473
This commit is contained in:
sdong 2015-10-26 16:02:32 -07:00
parent 7beb743cf5
commit ab0f3b964f
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tools/db_crashtest.py
View File

@ -245,20 +245,29 @@ def whitebox_crash_main(args):
# use large ops per thread since we will kill it anyway # use large ops per thread since we will kill it anyway
"ops_per_thread": 100 * cmd_params['ops_per_thread'], "ops_per_thread": 100 * cmd_params['ops_per_thread'],
} }
# run with kill_random_test # run with kill_random_test, with three modes.
# Mode 0 covers all kill points. Mode 1 covers less kill points but
# increases change of triggering them. Mode 2 covers even less
# frequent kill points and further increases triggering change.
if kill_mode == 0: if kill_mode == 0:
additional_opts.update({ additional_opts.update({
"kill_random_test": kill_random_test, "kill_random_test": kill_random_test,
}) })
elif kill_mode == 1: elif kill_mode == 1:
additional_opts.update({ additional_opts.update({
"kill_random_test": (kill_random_test / 3 + 1), "kill_random_test": (kill_random_test / 2 + 1),
"kill_prefix_blacklist": "WritableFileWriter::Append," "kill_prefix_blacklist": "WritableFileWriter::Append,"
+ "WritableFileWriter::WriteBuffered", + "WritableFileWriter::WriteBuffered",
}) })
elif kill_mode == 2:
# Run kill mode 0 and 1 by turn. additional_opts.update({
kill_mode = (kill_mode + 1) % 2 "kill_random_test": (kill_random_test / 4 + 1),
"kill_prefix_blacklist": "WritableFileWriter::Append,"
"WritableFileWriter::WriteBuffered,"
"PosixMmapFile::Allocate,WritableFileWriter::Flush",
})
# Run kill mode 0, 1 and 2 by turn.
kill_mode = (kill_mode + 1) % 3
elif check_mode == 1: elif check_mode == 1:
# normal run with universal compaction mode # normal run with universal compaction mode
additional_opts = { additional_opts = {

5
util/sync_point.cc
View File

@ -25,6 +25,11 @@ void TestKillRandom(std::string kill_point, int odds,
Random r((uint32_t)curtime); Random r((uint32_t)curtime);
assert(odds > 0); assert(odds > 0);
if (odds % 7 == 0) {
// class Rarndom uses multiplier 16807, which is 7^5. If odds are
// multiplier of 7, the first random value might have limited values.
odds++;
}
bool crash = r.OneIn(odds); bool crash = r.OneIn(odds);
if (crash) { if (crash) {
port::Crash(srcfile, srcline); port::Crash(srcfile, srcline);