From b1bea584571f216275ce4a123a85619c7f02e89b Mon Sep 17 00:00:00 2001 From: Mayank Agarwal Date: Tue, 19 Mar 2013 14:53:22 -0700 Subject: [PATCH] Fix more signed-unsigned comparisons Summary: Some comparisons left in log_test.cc and db_test.cc complained by make Test Plan: make Reviewers: dhruba, sheki Reviewed By: dhruba Differential Revision: https://reviews.facebook.net/D9537 --- db/db_test.cc | 2 +- db/log_test.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/db/db_test.cc b/db/db_test.cc index dc069a892..a9c83a7a4 100644 --- a/db/db_test.cc +++ b/db/db_test.cc @@ -1480,7 +1480,7 @@ TEST(DBTest, CompactionFilter) { while (iter->Valid()) { ParsedInternalKey ikey; ASSERT_EQ(ParseInternalKey(iter->key(), &ikey), true); - ASSERT_NE(ikey.sequence, 0); + ASSERT_NE(ikey.sequence, (unsigned)0); count++; iter->Next(); } diff --git a/db/log_test.cc b/db/log_test.cc index 1840090b3..367e2f18c 100644 --- a/db/log_test.cc +++ b/db/log_test.cc @@ -450,13 +450,13 @@ TEST(LogTest, ErrorJoinsRecords) { Write("correct"); // Wipe the middle block - for (int offset = kBlockSize; offset < 2*kBlockSize; offset++) { + for (unsigned int offset = kBlockSize; offset < 2*kBlockSize; offset++) { SetByte(offset, 'x'); } ASSERT_EQ("correct", Read()); ASSERT_EQ("EOF", Read()); - const int dropped = DroppedBytes(); + const unsigned int dropped = DroppedBytes(); ASSERT_LE(dropped, 2*kBlockSize + 100); ASSERT_GE(dropped, 2*kBlockSize); }