andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Serialize a space-hungry test (#9837)

Browse Source 
Summary:
Tends to fill up /dev/shm

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9837

Test Plan: Some manual testing

Reviewed By: hx235

Differential Revision: D35627568

Pulled By: pdillinger

fbshipit-source-id: 22710f7b10bc287570475dae42318dd346f78db9
This commit is contained in:
Peter Dillinger 2022-04-13 17:10:43 -07:00 committed by Facebook GitHub Bot
parent 5645207758
commit b3a6fb7e86
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Makefile
View File

@ -618,10 +618,13 @@ ROCKSDBTESTS_SUBSET ?= $(TESTS)
# env_test - suspicious use of test::TmpDir # env_test - suspicious use of test::TmpDir
# deletefile_test - serial because it generates giant temporary files in # deletefile_test - serial because it generates giant temporary files in
# its various tests. Parallel can fill up your /dev/shm # its various tests. Parallel can fill up your /dev/shm
# db_bloom_filter_test - serial because excessive space usage by instances
# of DBFilterConstructionReserveMemoryTestWithParam can fill up /dev/shm
NON_PARALLEL_TEST = \ NON_PARALLEL_TEST = \
c_test \ c_test \
env_test \ env_test \
deletefile_test \ deletefile_test \
db_bloom_filter_test \
PARALLEL_TEST = $(filter-out $(NON_PARALLEL_TEST), $(TESTS)) PARALLEL_TEST = $(filter-out $(NON_PARALLEL_TEST), $(TESTS))

5
db/db_bloom_filter_test.cc
View File

@ -1074,7 +1074,8 @@ class DBFilterConstructionReserveMemoryTestWithParam
}; };
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_CASE_P(
BlockBasedTableOptions, DBFilterConstructionReserveMemoryTestWithParam, DBFilterConstructionReserveMemoryTestWithParam,
DBFilterConstructionReserveMemoryTestWithParam,
::testing::Values(std::make_tuple(false, kFastLocalBloom, false, false), ::testing::Values(std::make_tuple(false, kFastLocalBloom, false, false),
std::make_tuple(true, kFastLocalBloom, false, false), std::make_tuple(true, kFastLocalBloom, false, false),
@ -1090,7 +1091,7 @@ INSTANTIATE_TEST_CASE_P(
std::make_tuple(true, kDeprecatedBlock, false, false), std::make_tuple(true, kDeprecatedBlock, false, false),
std::make_tuple(true, kLegacyBloom, false, false))); std::make_tuple(true, kLegacyBloom, false, false)));
// TODO: Speed up this test. // TODO: Speed up this test, and reduce disk space usage (~700MB)
// The current test inserts many keys (on the scale of dummy entry size) // The current test inserts many keys (on the scale of dummy entry size)
// in order to make small memory user (e.g, final filter, partitioned hash // in order to make small memory user (e.g, final filter, partitioned hash
// entries/filter/banding) , which is proportional to the number of // entries/filter/banding) , which is proportional to the number of